Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min width in confirmation dialog #5674

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

rkfg
Copy link
Contributor

@rkfg rkfg commented Dec 15, 2020

The minWidth style attribute in <Confirm> dialog should be removed. It doesn't make the dialog look much better and it adds a scroll bar for the contents on mobile.
Vanilla:
Screenshot_20201215-143843
Fixed:
Screenshot_20201215-143727

I use this component in my own code too and it's even worse when the confirmation text is long enough.

@fzaninotto fzaninotto merged commit 1632c3f into marmelab:master Dec 15, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.11.1 milestone Dec 15, 2020
@rkfg rkfg deleted the confirm-fix branch December 15, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants