Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: identity can be undefined on error and must be checked #5735

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

etienne-bondot
Copy link

@etienne-bondot etienne-bondot commented Jan 4, 2021

On login error or when cleaning the local storage, identity becomes undefined. As the UserMenu rendering occurred before the logout via checkError something else, we must check for identity existence before rendering the UserMenu to prevent the

Cannot read property 'fullName' of undefined

@djhi
Copy link
Contributor

djhi commented Jan 4, 2021

Thanks!

@djhi djhi added this to the 3.11.2 milestone Jan 4, 2021
@djhi djhi merged commit 2dbe004 into marmelab:master Jan 4, 2021
@etienne-bondot etienne-bondot deleted the fix/identity-can-be-undefined branch January 4, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants