Add ability to use record from context in Field components #5995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Back to WIP: I forgot to set the correct record in Reference fields |
|
And back to RFR |
djhi
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
recordprop injection in fields is magical, and a source of incomprehension for react-admin learners. Why do<TextField source="title" />work as a<Datagrid>child, but not in a custom Show layout?We've recently introduced the
RecordContext. It's time we enable support for this context in Field components, to remove the incomprehension.This change is totally backwards compatible. It also prepares v4, where we'll remove the
recordprop injection.