Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Yarn #6540

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Fix Yarn #6540

merged 4 commits into from
Aug 30, 2021

Conversation

quentingarcia
Copy link
Contributor

@quentingarcia quentingarcia commented Aug 29, 2021

react-admin is a monorepo

To specify the topology to Lerna, we need to include packages in devDependencies and peerDependencies.
This will help Lerna to understand the dependency.
When possible, we prefer to use "devDependencies" and "peerDependencies" instead of "dependencies"

Edit multiple package.json dependencies to fix yarn install/build errors.

quentingarcia and others added 4 commits August 24, 2021 10:51
To specify the topology we need to include packages in devDependencies and peerDependencies.
This will help Lerna to understand the dependency.
When possible, we prefer to use "devDependencies" and "peerDependencies" instead of "dependencies"
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, this indeed fixes the build workflow when not using the make commands. Thanks!

@djhi djhi added this to the 3.18 milestone Aug 30, 2021
@djhi djhi merged commit 8010aeb into marmelab:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants