[RFR] Add rich text input toolbar buttons #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also just noticed that the toolbar is not responsive (missing the flex-wrap so the screen has an horizontal scroll bar). |
slax57
requested changes
Jun 14, 2022
|
Thanks for the kind feedback :) |
Yes, thank you for this reminder. We're going to include english and french translations directly inside this package. |
antoinefricker
approved these changes
Jun 15, 2022
slax57
approved these changes
Jun 16, 2022
|
Could you please fix the linter warnings? |
Sorry I introduced them in my last code review commit and did not pay attention. |
fzaninotto
approved these changes
Jun 17, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #7806, here is the PR to have both ColorButtons (including font and highlight color) and ImageButtons components for RichTextInput toolbar.
This is my first PR ever on any non-private repository, so please feel free to make me some feedbacks (english or french).
Plus, I noticed that the translation of all buttons (existing ones as well) do not exist, so even in french the titles are in english (default).