Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ra-data-graphql-simple response parser for embedded arrays and objects #7895

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jun 24, 2022

Problem

When a record has embedded arrays or objects that are not references, ra-data-graphql-simple still generates fields to handle references for them. This leads to invalid payloads sent to the backend when updating for instance

Solution

Check that embedded arrays and objects have identifiers before generating the field required for references. This is still not perfect but ra-data-graphql-simple shouldn't be used for real applications anyway

@fzaninotto fzaninotto merged commit 1b2af67 into master Jun 24, 2022
@fzaninotto fzaninotto deleted the fix-ra-data-graphql-simple-embedded-detection branch June 24, 2022 14:42
@fzaninotto fzaninotto added this to the 4.2.1 milestone Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants