Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leading character in AutocompleteInput can not be deleted #7954

Merged

Conversation

antoinefricker
Copy link
Contributor

Fix #7935

@antoinefricker antoinefricker added the RFR Ready For Review label Jul 8, 2022
@antoinefricker antoinefricker changed the title Fix Can not delete leading character in AutocompleteInput Fix leading character in AutocompleteInput can not be deleted Jul 8, 2022
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@cduran-seeri
Copy link

Thank you for the PR!

@vanessa-sun
Copy link

Thank you for the PR!

@afilp
Copy link
Contributor

afilp commented Jul 21, 2022

Can this be merged please, even without a test? Thanks a lot!

@fzaninotto fzaninotto merged commit d5ea810 into master Jul 21, 2022
@fzaninotto fzaninotto deleted the 7935-fix-delete-leading-character-autocomplete-input branch July 21, 2022 12:14
@davidhenley
Copy link
Contributor

davidhenley commented Jul 26, 2022

Thanks @septentrion-730n!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete leading character in AutocompleteInput
7 participants