Add requireAuth to <Authenticated /> component
#7993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Jul 21, 2022
djhi
changed the title
pessimistic mode to <Authenticated /> componentpessimistic mode to <Authenticated /> component
djhi
changed the title
pessimistic mode to <Authenticated /> componentrequiredAuth to <Authenticated /> component
djhi
changed the title
requiredAuth to <Authenticated /> componentrequireAuth to <Authenticated /> component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
useAuthenticated()hook and old<Authenticated />component is always optimistic, other auth hooks cannot be used directly inside<Route element>and causes boilerplate, and<Admin requireAuth>completely disallows anonymous access to all the pages.This feature gives user finer granularity of control of which custom routes can be anonymously accessed, which can be optimistically rendered, and which should not leak the UI and does not have flash of UI.