Fix List page display on dataProvider error
#8319
Conversation
| @@ -70,7 +66,7 @@ export const ListView = <RecordType extends RaRecord = any>( | |||
| }) | |||
| : children} | |||
| </Content> | |||
| {pagination !== false && pagination} | |||
| {error ? <PaginationLimit /> : pagination !== false && pagination} | |||
There was a problem hiding this comment.
I don't think you should say 'no results found' in case of error.
There was a problem hiding this comment.
In my latest commit, I've customized the PaginationLimit component to accept a message prop instead of being a dummy component
It shows the notification error, renders the empty "No results found" view for a blink and gets back to render the previous page |
| @@ -70,7 +66,11 @@ export const ListView = <RecordType extends RaRecord = any>( | |||
| }) | |||
| : children} | |||
| </Content> | |||
| {pagination !== false && pagination} | |||
| {error ? ( | |||
| <PaginationLimit message="ra.notification.data_provider_error" /> | |||
There was a problem hiding this comment.
It feels weird to me to render a component named 'pagination' here, since we don't even know if the data is supposed to be paginated or not.
I understand that the code of the component you want to display is very similar to the code of PaginationLimit, but to me they have different purposes, so they should be two different components (even if the code is duplicated).
There was a problem hiding this comment.
How about adding an Error component:
<Error error={error} resetErrorBoundary={null} />
There was a problem hiding this comment.
I'm not too found of this solution either, cause we don't do it for other dataProvider errors, so why only do it for the list?
To me, the content of the PaginationLimit was enough for our needs (provided we change the message of course), but I just thought we should create a separate component for this use.
However, this Error component makes me realize it could be a welcome addition to add a 'Retry' button, that would call refresh from useRefresh. This could be useful in case it's only a temporary error.
What do you think?
There was a problem hiding this comment.
I like the idea of the Error page. Displaying an empty page with a warning is less user friendly IMHO.
|
Okay for me! |
Fixes #8241
Before
After
