Fix onError type #8667
Merged
Fix onError type #8667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
reviewed
Feb 20, 2023
packages/ra-core/src/types.ts
Outdated
| export type onError = (error?: any, variables?: any, context?: any) => void; | ||
| export type OnError = onError; |
There was a problem hiding this comment.
I'd do it the other way around
export type OnError = (error?: any, variables?: any, context?: any) => void;;
// @deprecated - use OnError instead
export type onError = OnError
|
Can you please add a description? |
slax57
approved these changes
Feb 20, 2023
fzaninotto
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
onErrortype name to be Pascal cased like the others