Fix AppBar with alwaysOn hides sidebar menu on scroll #8856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
Apr 26, 2023
Comment on lines
-77
to
-82
| export const AlwaysOn = () => ( | ||
| <Wrapper> | ||
| <AppBar alwaysOn /> | ||
| </Wrapper> | ||
| ); | ||
|
|
There was a problem hiding this comment.
I don't think you should remove this story as this still works, right?
There was a problem hiding this comment.
That's true but I don't want to encourage people to use it
djhi
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Setting
<AppBar alwaysOn>can hide the top part of the side menu on scrollPeek.24-04-2023.18-20.webm
Solution
Introduce a new prop
appBarAlwaysOnon<Layout>, allowing to share this prop both with<AppBar>and<SideBar>.AppBar'salwaysOnprop has been removed from the doc and the stories, and the JSDoc indicates it should not be used with the default layout of RA, and<Layout appBarAlwaysOn>should be used instead.