Simplify form reset on record change, and forward supported props from useAugmentedForm to useForm
#8911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
commented
May 15, 2023
| @@ -1119,7 +1119,7 @@ describe('<AutocompleteInput />', () => { | |||
| <SimpleForm | |||
| mode="onBlur" | |||
| onSubmit={jest.fn()} | |||
| defaultValues={{ role: 2 }} | |||
| defaultValues={{ language: 'ang' }} | |||
There was a problem hiding this comment.
To me these tests have nothing to do with changing the defaultValues (I think it's a copy paste error), hence I changed that to keep the same defaultValues across rerenders.
slax57
changed the title
resetOptionsuseAugmentedForm to useForm
djhi
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
form.reset()automatically when therecord(ordefaultValues) changeuseAugmentedFormto RHF'suseForm, theresetOptionsin particularuseInitializeFormWithRecordAdditional info
Had to change the tests because this comes with a minor BC, in case the
defaultValueschange when there is norecord:=> But the way I see it it's rather a bug fix than a BC, because I would expect changes in the
defaultValuesto be reflected in the form, regardless of the presence of arecord.