Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create-react-admin does not include its templates #8932

Merged
merged 1 commit into from
May 22, 2023

Conversation

djhi
Copy link
Contributor

@djhi djhi commented May 22, 2023

No description provided.

@slax57 slax57 added this to the 4.11.0 milestone May 22, 2023
@slax57 slax57 merged commit 9758e15 into master May 22, 2023
@slax57 slax57 deleted the fix-create-react-admin branch May 22, 2023 09:05
@dnk8n
Copy link

dnk8n commented May 22, 2023

I am running into this? Is there a workaround?

Update: What worked for me, was:

  1. cloning this repo
  2. yarn create react-app example
  3. Just before answering which resources to add, from packages/create-react-app of this repo cp -a templates /home/dean/.config/yarn/global/node_modules/create-react-admin/
  4. Continue with create-react-app installation

@djhi djhi modified the milestones: 4.11.0, 4.10.5 May 22, 2023
@slax57
Copy link
Contributor

slax57 commented May 22, 2023

I am running into this? Is there a workaround?

@dnk8n I guess you could paste the missing templates folder in your ~/.config/yarn/global/node_modules/create-react-admin (this is for yarn, might require adaptation for npm), even though this is of course really ugly 🤷

@dnk8n
Copy link

dnk8n commented May 22, 2023

Note, need to do it mid installation. Copying the templates before, causes them to be cleared out again.

@fzaninotto
Copy link
Member

We'll release a new version shortly that removes the need for this manual copy / paste.

@dnk8n
Copy link

dnk8n commented May 22, 2023

Please can 4.10.5 be released to npm when it is ready? I notice that sometimes releases don't make it to npm (4.10.4 for example). Alternatively, is there some docs on how to manually install from source?

@fzaninotto
Copy link
Member

Version 4.10.4 was released (https://www.npmjs.com/package/react-admin). What makes you think it wasn't?

@djhi
Copy link
Contributor Author

djhi commented May 22, 2023

We released version 4.10.5 that includes this fix.
Full release notes here: https://github.com/marmelab/react-admin/releases/tag/v4.10.5

@dnk8n
Copy link

dnk8n commented May 22, 2023

Version 4.10.4 was released (https://www.npmjs.com/package/react-admin). What makes you think it wasn't?

I meant 4.10.4 was missing for https://www.npmjs.com/package/create-react-admin?activeTab=versions

@joanllodrariera
Copy link

joanllodrariera commented May 23, 2023

Since this upgrade 4.10.5 (4.10.4 was fine) I'm receiving the error: [commonjs--resolver] Failed to resolve entry for package "ra-language-french". The package may have incorrect main/module/exports specified in its package.json.

@djhi @fzaninotto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants