Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Remove emptyText prop from <AutoCompleteArrayInput> doc as it is not supported #9073

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Jul 4, 2023

Here is the GitStart Ticket for this pull request: RA-OSS-10

  • Please mark your PR as "ready for review" when you have completed all requirements.
  • Please ensure that your PR is reviewed by at least 2 people after you have completed it.
  • Comments for review or requested changes from the upstream client will be notified to you by email and will also show on the ticket page.
  • After the PR is merged on the upstream, please merge this PR.
  • If there exist merge conflicts on your current PR and you have to close the PR instead of merging it, please go to the ticket page to manually finish the task that is related to this PR.

https://www.loom.com/share/3ba845e8ded54d34a24b23b30528d782?sid=300cb3dc-7dd8-4306-9418-e3bba8ba79ac

Happy hacking! 🎉


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: passy4ucj <ojinnnakapascal@gmail.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice catch, thanks!

However, I disagree with the fix.

Currently this adds the emptyText to the list of choices, but it becomes selectable (which is not suitable) and besides it still does not appear automatically when the input is empty.

IMO we should rather change the docs to say that AutocompleteArrayInput simply does not support this prop.

@djhi @fzaninotto do you confirm?

gitstart and others added 2 commits July 13, 2023 10:14
Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: passy4ucj <ojinnnakapascal@gmail.com>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
@gitstart
Copy link
Contributor Author

This is a nice catch, thanks!

However, I disagree with the fix.

Currently this adds the emptyText to the list of choices, but it becomes selectable (which is not suitable) and besides it still does not appear automatically when the input is empty.

IMO we should rather change the docs to say that AutocompleteArrayInput simply does not support this prop.

@djhi @fzaninotto do you confirm?

Ok the emptyText props have been removed from the AutocompleteArrayInput docs

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slax57 slax57 added this to the 4.12.2 milestone Jul 17, 2023
@slax57 slax57 merged commit 0db0e81 into marmelab:master Jul 17, 2023
@slax57 slax57 changed the title RA-OSS-10 - The documentation says that <AutoCompleteArrayInput> supports the emptyText property, but it does not work. [Doc] Remove emptyText prop from <AutoCompleteArrayInput> doc as it is not supported Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants