Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call checkError when getPermissions fails #9117

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Call checkError when getPermissions fails #9117

merged 2 commits into from
Jul 21, 2023

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jul 21, 2023

Problem

When declaring resources at runtime, we don't check for authorization related errors and as no resources were returned, RA displays an empty page.

Solution

When getPermissions rejects, pass the error to checkError to allow redirecting to the login page

@djhi djhi added the RFR Ready For Review label Jul 21, 2023
@slax57 slax57 added this to the 4.12.2 milestone Jul 21, 2023
@slax57 slax57 merged commit 656f1ba into master Jul 21, 2023
8 checks passed
@slax57 slax57 deleted the check-permissions-error branch July 21, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.12.2
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @slax57