Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated defaultProps in jsx components #9124

Merged
merged 53 commits into from
Jul 31, 2023
Merged

Remove deprecated defaultProps in jsx components #9124

merged 53 commits into from
Jul 31, 2023

Conversation

adguernier
Copy link
Contributor

@adguernier adguernier commented Jul 24, 2023 •
edited by fzaninotto
Loading

Fix #9112 by removing default props in jsx components and use destructuring default values instead

@adguernier
remove defaultProps in ReferenceField and une destructuring instead
bca8db1
@adguernier
remove defaultProps in Login and use destructuring instead
08bdb97
@adguernier
remove defaultProps in BulkUpdateButton and use destructuring instead
c756a46
@adguernier
remove defaultProps in NumberField and use destructuring instead
08b649e
@adguernier
remove defaultProps in ReferenceManyInput and use destructuring instead
fabe44a
@adguernier
remove defaultProps in ReferenceOneField and use destructuring instead
670dc2f
@adguernier
remove defaultProps in SelectField ans use destructuring instead
6d21201
@adguernier
remove defaultProps in BooleanInput and use destructuring instead
eaa1fad
@adguernier
remove defaultProps in FileInputPreview and use destructuring instead
117f957
@adguernier
remove defaultProps and useless props in NumberInput and use destruct…
7412886 
…uring instead
@adguernier
remove defaultProps in RadioButtonGroupInput and use destructuring in…
cfe504b 
…stead
@adguernier adguernier added the WIP Work In Progress label Jul 24, 2023
@adguernier
extract options param to avoid new instance of an object at each render
51f74be
@adguernier
remoce useless default param
ad0b4af
@adguernier
extract options params to avoid a new instance of an object at each r…
cda1eeb 
…ender
@adguernier
remove useless default value
8f6a113
@adguernier
extract default filter param
5ecc5a7
@adguernier
extract default options param
5a1ee3d
@adguernier
extract default filter param
26de41c
@adguernier
extract default filter param
28f31d8
@adguernier
extract default selectIds and onUnselectItems param
6b988d9
@adguernier
extract default data param
e2da27c
@adguernier
step and textAlign defaultProps in NumberInput as before
cec5eb3
@adguernier
removed options in TextInput propTypes as they are not used
2531c51
@adguernier
removed options in SelectInput propTypes as they are not used
17c51aa
@adguernier
removed options in NumberInput propTypes as they are not used
6ae0220
@adguernier
removed required from hasBulkActions in propTypes as is not required …
baa1f4c 
…in DatagridRowProps
@fzaninotto fzaninotto merged commit 60a4332 into master Jul 31, 2023
8 checks passed
@fzaninotto fzaninotto deleted the 9112-destructuring-defaultprops branch July 31, 2023 13:07
@fzaninotto fzaninotto added this to the 4.12.4 milestone Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
WIP Work In Progress
Projects
None yet
Milestone
4.12.4
Development

Successfully merging this pull request may close these issues.

Warning: ReferenceField: Support for defaultProps will be removed from function components
2 participants
@adguernier @fzaninotto