Fix FilterLiveSearch reset button does not reset the value #9149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Jul 31, 2023
| @@ -21,70 +21,6 @@ const UseList = ({ | |||
| }; | |||
|
|
|||
| describe('<useList />', () => { | |||
| it('should filter string data based on the filter props', () => { | |||
There was a problem hiding this comment.
I moved these tests further down to group them in the describe('filter') group, I didn't remove or modify them
| ); | ||
| }); | ||
|
|
||
| it('should apply the q filter as a full-text filter', () => { |
There was a problem hiding this comment.
This is the only new test
adguernier
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9106
FilterLiveSearch used react-admin's
<Form>, which did too many things and caused the bug. Switching to a simple form powered byuseFormfixes the issue.I had to augment
useListto make a real-life filterable list and unit test<FilterLiveSearch>.