Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <TopToolbar>: React does not recognize the hasCreate prop on a DOM element #9267

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix <TopToolbar>: React does not recognize the hasCreate prop on a DOM element #9267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/ra-ui-materialui/src/layout/TopToolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const TopToolbar = (props: ToolbarProps) => {
<StyledToolbar
disableGutters
variant={isXSmall ? 'regular' : 'dense'}
{...props}
{...sanitizeToolbarRestProps(props)}
/>
);
};
Expand Down Expand Up @@ -46,3 +46,5 @@ const StyledToolbar = styled(Toolbar, {
paddingBottom: 0,
},
}));

const sanitizeToolbarRestProps = ({ hasCreate, ...props }: any) => props;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably add the others as well, hasList, etc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasCreate is the only superfluous prop injected by ListView (through ListToolbar).

Loading