Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix i18next translation provider fails to use smart_count #9400

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Fix i18next translation provider fails to use smart_count #9400

merged 2 commits into from
Oct 27, 2023

Conversation

erwanMarmelab
Copy link
Contributor

Problem

The bulk actions toolbar label doesn’t replace the token with the value

Solution

Change the variable name from count to smart_count on the i18nextProbider

Before

image

After

image

@erwanMarmelab erwanMarmelab added the RFR Ready For Review label Oct 26, 2023
slax57
slax57 reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include the fix in the story, to avoid calling convertRaTranslationsToI18next twice?

@fzaninotto fzaninotto merged commit 4b0d058 into master Oct 27, 2023
11 checks passed
@fzaninotto fzaninotto deleted the fix-i18next-translation-provider-fails-to-use-smart-count branch October 27, 2023 09:53
@fzaninotto fzaninotto added this to the 4.15.2 milestone Oct 27, 2023
@fzaninotto fzaninotto changed the title Fix i18next translation provider fails to use smart count in BulkActionsToolbar Fix i18next translation provider fails to use smart_count Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 left review comments

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi Awaiting requested review from djhi

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.15.2
Development

Successfully merging this pull request may close these issues.
3 participants
@erwanMarmelab @fzaninotto @slax57