-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Add documentation for <CheckForApplicationUpdate onNewVersionAvailable>
#9437
Conversation
Thanks for the PR. I think the hook should remain private - we just can't document all hooks, or the doc will become too large. As the component supports all the props of the hook, you should just document the |
Thanks! |
Hi @fzaninotto The Props for typescript should probably be updated, we should no longer omit the callback in the props. Also there should be no space in the documentation for the prop https://github.com/marmelab/react-admin/blob/master/docs/CheckForApplicationUpdate.md?plain=1#L49 |
<CheckForApplicationUpdate onNewVersionAvailable>
Closes #9432