Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add example showing how to add <Inspector> to a custom layout #9458

Merged

Conversation

rossb220
Copy link
Contributor

@rossb220 rossb220 commented Nov 20, 2023

Just adding a comment regarding the Inspector component. If this doesn't exist on a custom layout the configuration feature does not seem to work i.e the popup fails to appear

@fzaninotto
Copy link
Member

Thanks! Could you please add an example of a custom layout with embedded Inspector in this new section?

@rossb220 rossb220 force-pushed the hotfix/configuration-inspector-component branch from 4705c39 to 3cec219 Compare November 20, 2023 18:15
@rossb220
Copy link
Contributor Author

rossb220 commented Nov 20, 2023

@fzaninotto Done

I've also added further information regarding the <WrapperField> component. I was able to use it within a <SimpleFormConfigurable> using the source prop. The label prop didn't seem to work

docs/Configurable.md Outdated Show resolved Hide resolved
docs/Configurable.md Outdated Show resolved Hide resolved
docs/Configurable.md Outdated Show resolved Hide resolved
docs/WrapperField.md Outdated Show resolved Hide resolved
docs/WrapperField.md Outdated Show resolved Hide resolved
@slax57
Copy link
Contributor

slax57 commented Nov 24, 2023

Thanks for the changes.

Unfortunately it seems I do not have the permissions to commit on your branch, so unfortunately I can't commit the suggested changes myself.
Can you please accept them?

Thanks.

rossb220 and others added 5 commits November 24, 2023 10:15
Co-authored-by: Jean-Baptiste Kaiser <jbaptiste.kaiser@gmail.com>
Co-authored-by: Jean-Baptiste Kaiser <jbaptiste.kaiser@gmail.com>
Co-authored-by: Jean-Baptiste Kaiser <jbaptiste.kaiser@gmail.com>
Co-authored-by: Jean-Baptiste Kaiser <jbaptiste.kaiser@gmail.com>
Co-authored-by: Jean-Baptiste Kaiser <jbaptiste.kaiser@gmail.com>
@rossb220
Copy link
Contributor Author

@slax57 That's been done but would you like me to squash the commits?

@slax57
Copy link
Contributor

slax57 commented Nov 24, 2023

No need I'll do it when merging. Thanks a lot! 🙏

@slax57 slax57 added this to the 4.16.1 milestone Nov 24, 2023
@slax57 slax57 merged commit 2c9e1d0 into marmelab:master Nov 24, 2023
1 of 2 checks passed
@slax57 slax57 changed the title docs: inspector component details for configuration feature [Doc] Add example showing how to add <Inspector> to a custom layout Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants