Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix snippets fails to render in JS #9478

Merged
merged 2 commits into from
Nov 28, 2023
Merged

[Doc] Fix snippets fails to render in JS #9478

merged 2 commits into from
Nov 28, 2023

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Nov 28, 2023

Before

image

After

image

@@ -305,7 +305,7 @@ interface DeleteParams {
interface DeleteResult {
data: Record;
}
function delete(resource: string, params: DeleteParams): Promise<DeleteResult>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete is a reserved word, so there is no other way to make it compile

@slax57 slax57 added this to the 4.16.2 milestone Nov 28, 2023
@slax57 slax57 merged commit 802bab4 into master Nov 28, 2023
5 checks passed
@slax57 slax57 deleted the doc-fix-js branch November 28, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants