Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Improve EditableDatagrid doc #9494

Merged
merged 3 commits into from
Dec 7, 2023
Merged

[Doc] Improve EditableDatagrid doc #9494

merged 3 commits into from
Dec 7, 2023

Conversation

adguernier
Copy link
Contributor

The OSS version of the EditableDatagrid is very poor.

This PR attemps to make it rich!

@adguernier adguernier added the RFR Ready For Review label Dec 6, 2023
@fzaninotto fzaninotto self-requested a review December 6, 2023 13:02
fzaninotto
fzaninotto approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor remarks:

  • This article could use more screenshots / screencasts
  • the first example doesn't match the initial screencast

But that's already way better than the previous version!

@slax57 slax57 self-assigned this Dec 7, 2023
slax57
slax57 requested changes Dec 7, 2023
View reviewed changes
docs/EditableDatagrid.md Outdated Show resolved Hide resolved
docs/EditableDatagrid.md Outdated Show resolved Hide resolved
@slax57 slax57 removed their assignment Dec 7, 2023
@slax57 slax57 added this to the 4.16.3 milestone Dec 7, 2023
@slax57 slax57 merged commit 5533ef5 into master Dec 7, 2023
2 checks passed
@slax57 slax57 deleted the expand-editable-data-grid-doc branch December 7, 2023 10:28
@slax57 slax57 changed the title doc: improve EditableDatagrid doc [Doc] Improve EditableDatagrid doc Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.16.3
Development

Successfully merging this pull request may close these issues.
3 participants
@adguernier @fzaninotto @slax57