Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <AutocompleteInput> should keep working when passing custom InputProps #9559

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Fix <AutocompleteInput> should keep working when passing custom InputProps #9559

merged 3 commits into from
Jan 5, 2024

Conversation

adguernier
Copy link
Contributor

@adguernier adguernier commented Jan 4, 2024 •
edited
Loading

Problem

Passing InputProps to the TextFieldProps prop of <AutocompleteInput> works but it leads to break the Autocomplete behavior we want to keep.

Solution

Merge InputProps to apply them AND keep the Autocomplete behavior

image

@adguernier adguernier added the WIP Work In Progress label Jan 4, 2024
@adguernier adguernier changed the title fix: merge InputProps so Autocomplete still works fix: keep autocomplete behavior even if custom InputProps are set Jan 4, 2024
@adguernier adguernier added RFR Ready For Review and removed WIP Work In Progress labels Jan 4, 2024
@adguernier adguernier marked this pull request as ready for review January 4, 2024 16:32
djhi
djhi reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it more beautiful?
image

@adguernier
Copy link
Contributor Author

make it more beautiful

Done

@djhi
Copy link
Contributor

djhi commented Jan 5, 2024

make it more beautiful

Done

image

Screenshot?

@adguernier
Copy link
Contributor Author

adguernier commented Jan 5, 2024 •
edited
Loading

make it more beautiful

Done

image

Screenshot?

See above, in the description 👆

@djhi djhi added this to the 4.16.5 milestone Jan 5, 2024
@djhi djhi merged commit bb68925 into master Jan 5, 2024
11 checks passed
@djhi djhi deleted the fix-autocomplete-input-props-are-overrided branch January 5, 2024 08:54
@slax57 slax57 changed the title fix: keep autocomplete behavior even if custom InputProps are set Fix <AutocompleteInput> should keep working when passing custom InputProps Jan 5, 2024
fzaninotto added a commit that referenced this pull request Feb 25, 2024
@fzaninotto
Fix AutocompleteInput ignores TextFieldProps
dd6bb4d 
Autocomplete accepts TextFieldProps, which allows to override the props of the inner TextField (see https://mui.com/material-ui/api/text-field/). This ability was lost in #9559
@fzaninotto fzaninotto mentioned this pull request Feb 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.16.5
Development

Successfully merging this pull request may close these issues.
2 participants
@adguernier @djhi