Upgrade vite dependencies #9565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adguernier
approved these changes
Jan 8, 2024
slax57
requested changes
Jan 8, 2024
There was a problem hiding this comment.
This mostly works fine (tested the demo and the builds).
However this raises 2 new warnings:
- new warnings about sourcemap when running
make build-demo
../../node_modules/@mui/material/utils/index.js (1:0) Error when using sourcemap for reporting an error: Can't resolve original location of error.
../../node_modules/@mui/material/styles/index.js (1:0) Error when using sourcemap for reporting an error: Can't resolve original location of error.
../../node_modules/@mui/material/Box/Box.js (1:0) Error when using sourcemap for reporting an error: Can't resolve original location of error.
../../node_modules/@mui/material/utils/createSvgIcon.js (1:0) Error when using sourcemap for reporting an error: Can't resolve original location of error.
../../node_modules/@mui/material/Accordion/Accordion.js (1:0) Error when using sourcemap for reporting an error: Can't resolve original location of error.
../../node_modules/@mui/material/AccordionDetails/AccordionDetails.js (1:0) Error when using sourcemap for reporting an error: Can't resolve original location of error.
../../node_modules/@mui/material/AccordionActions/AccordionActions.js (1:0) Error when using sourcemap for reporting an error: Can't resolve original location of error.
and tons of others like this...
any idea where this might come from?
- new yarn warning when running
make install
YN0060: │ @types/node is listed by your project with version 17.0.9, which doesn't satisfy what vite (p30fa6) requests (^18.0.0 || >=20.0.0).
|
I fixed the second but can't figure out the first. I suspect we'll have to upgrade more packages. |
slax57
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.