Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Make the BC about using a data router clearer in the Upgrade guide #9696

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Mar 1, 2024

No description provided.


If you are using an external router, you will need to migrate it to a data router.

For instance, if you were using `react-router`'s `BrowserRouter`, you will need to migrate to `createBrowserRouter` and wrap your app in a `RouterProvider`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to react-router documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

docs/Upgrade.md Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit 8d414a4 into next Mar 4, 2024
2 checks passed
@fzaninotto fzaninotto deleted the data-router-upgrade-guide branch March 4, 2024 09:04
@fzaninotto fzaninotto modified the milestones: 4.16.13, 5.0.0 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants