[Typescript] Fix compilation error in MenuItemLink
, ResettableTextField
and InpectorButton
with latest @types/react
#9853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9737
Problem
@types/react v18.2.66 update makes some of our components require extra props.
MenuItemLink
- requiresonPointerEnterCapture
,onPointerLeaveCapture
ResettableTextField
- requiresonPointerEnterCapture
,onPointerLeaveCapture
InspectorButton
- requiresonPointerEnterCapture
,onPointerLeaveCapture
andplaceholder
Probably InspectorButton.placeholder issue was introduced even before v18.2.66
This breaks new apps bootstrapped from
create-react-admin
- you'll get typescript error if using these componentsSolution
Explicitly omit these otherwise junk props and allow to use the components without compilation error