Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] [Storybook] Fix some stories appear broken on devices which prefer dark mode #9880

Merged
merged 4 commits into from
May 29, 2024

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented May 28, 2024

The following stories appeared broken when rendered on a device which prefers dark mode:

This is because the color scheme applied is intended for dark backgrounds, but it is currently white.
Adding a MUI Paper fixes the issue.

@fzaninotto
Copy link
Member

The problem is that, in dark mode, MUI components expect to be rendered on a dark background. Instead of forcing the theme, we should render these stories on a Paper to force a dark background in dark mode.

@slax57
Copy link
Contributor Author

slax57 commented May 29, 2024

The problem is that, in dark mode, MUI components expect to be rendered on a dark background. Instead of forcing the theme, we should render these stories on a Paper to force a dark background in dark mode.

Fixed

@fzaninotto fzaninotto merged commit 987b6e5 into next May 29, 2024
14 checks passed
@fzaninotto fzaninotto deleted the fix-storybook-v5-issues branch May 29, 2024 12:08
@fzaninotto fzaninotto added this to the 5.0.0 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants