Allow to customize Login page icon with <Login avatarIcon>
#9917
Conversation
There was a problem hiding this comment.
Thanks for the PR, which I approve.
However, since this is a new feature, it needs to target the next branch. Can you rebase?
As a reminder, React Admin v4 is now feature-freeze, which means this new feature will have to be released with React Admin v5.
Thanks again for your contribution!
mjarosch
force-pushed
the
feature/login-avatar-icon
branch
4 times, most recently
from
a91a5be
to
7755320
Compare
|
@slax57 Branch has been rebased. |
|
Would you mind adding a story for it? We don't have any for this component so take inspiration from the |
|
It seems your branch now includes too many commits. Looks like you messed up the rebase 😬 . Can you fix the branch? 🙏 |
mjarosch
force-pushed
the
feature/login-avatar-icon
branch
from
d191ed9
to
4829269
Compare
mjarosch
force-pushed
the
feature/login-avatar-icon
branch
from
4829269
to
6f10f1c
Compare
|
@slax57 Not sure what happened, but the branch has been cleaned up. I still plan on getting a story added for this, I just have been busy and haven't had time to get to it. |
|
No worries, we'll wait on the story then. Thanks! |
slax57
changed the title
<Login avatarIcon>
This is a pull request for issue #9916. It adds an avatarIcon property to the Login component w/ a default of the Lock icon. This allows for overriding the icon without having to copy the complete component.
Ideally, this would be included as part of a v4 point release. This is my first pull request, so please let me know if there is anything else needed.
--
Fix #9916