Update <ReferenceField> to render a link to the show view when relevant
#9951
Conversation
fzaninotto
changed the title
<ReferenceField> to render a link to the show view when relevant
| @@ -146,25 +145,21 @@ export const ReferenceFieldView = < | |||
| if (link) { | |||
| return ( | |||
| <Root className={className} sx={sx}> | |||
| <RecordContextProvider value={referenceRecord}> | |||
There was a problem hiding this comment.
The RecordContextProvider was added twice, as ReferenceFieldBase already does it.
packages/ra-core/src/controller/field/useReferenceFieldController.ts
Outdated
Show resolved
Hide resolved
| const resourceDefinition = useResourceDefinition({ resource }); | ||
|
|
||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| const linkFunc = useCallback( |
There was a problem hiding this comment.
We cannot use useEvent here because we need to call the function right away, and useEvent throws an Error in that case.
There was a problem hiding this comment.
That means that if the function did change, it will never be updated here though right?
There was a problem hiding this comment.
yes indeed, that's a limitation I'm willing to accept
| navigate(type); | ||
| if (path === false || path == null) { | ||
| return; | ||
| } | ||
| navigate(path, { | ||
| state: { _scrollToTop: true }, | ||
| }); |
There was a problem hiding this comment.
This is a small breaking change: if the user passed a path or a function that returns a path, it will have scrollToTop: true while it used not to.
But it's easy to bypass by using a function that calls navigate itself and returns false to cancel the default navigation.
Problem
<ReferenceField>renders a link to the edit view by default. When a resource has a show view but no edit view, and the developer hasn't specified thelinktype, a<ReferenceField>targeting that resource doesn't show any link.Also, when there is a conflict between the
<ReferenceField link>and the associated<Resource>(e.g. when the developer specified that theReferenceFieldshould link to theeditview even though theResourcedoesn't defined such a view), react-admin ignores the developer choice and removes the link. Yet the developer may want to link to a nestedCustomRoutethat matches thelink.Solution
Make
<ReferenceField>default toshowwhenlinkis undefined and there are both an edit and a show view.Make
<ReferenceField>smarter so that it can link to the show view if it exists.Make
<ReferenceField>always honor thelinkprop.Before
This PR
The link behavior of
<Datagrid rowClick>,<ReferenceField link>and<ReferenceOneField link>is now consistent.