Merge pull request #277 from marp-team/auto-trigger-directive-value-c…

…ompletion Auto-trigger suggestion for value of supported directives
marp-team · Aug 21, 2021 · 9a43048 · 9a43048
2 parents cac9dc8 + 5065036
commit 9a43048
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 - Auto completion for [`size` global directive](https://github.com/marp-team/marp-core#size-global-directive) ([#276](https://github.com/marp-team/marp-vscode/pull/276))
 - `unknown-size` diagnostic: Notify if the specified size preset was not defined in a theme ([#276](https://github.com/marp-team/marp-vscode/pull/276))
+- Auto-trigger suggestion for value of supported directives ([#277](https://github.com/marp-team/marp-vscode/pull/277))
 
 ### Changed
 

diff --git a/src/directives/definitions.ts b/src/directives/definitions.ts
@@ -25,6 +25,7 @@ export enum DirectiveProvidedBy {
 
 interface DirectiveInfoBase {
   allowed: readonly DirectiveDefinedIn[]
+  completable?: boolean
   description: string
   details?: string
   markdownDescription: MarkdownString
@@ -94,6 +95,7 @@ export const builtinDirectives = [
     providedBy: DirectiveProvidedBy.Marpit,
     type: DirectiveType.Global,
     details: 'https://marpit.marp.app/directives?id=theme',
+    completable: true,
   }),
   createDirectiveInfo({
     name: 'style',
@@ -146,6 +148,7 @@ export const builtinDirectives = [
     providedBy: DirectiveProvidedBy.Marpit,
     type: DirectiveType.Local,
     details: 'https://marpit.marp.app/directives?id=pagination',
+    completable: true,
   }),
   createDirectiveInfo({
     name: 'header',
@@ -270,6 +273,7 @@ export const builtinDirectives = [
     providedBy: DirectiveProvidedBy.MarpCore,
     type: DirectiveType.Global,
     details: 'https://github.com/marp-team/marp-core#math-global-directive',
+    completable: true,
   }),
   createDirectiveInfo({
     name: 'size',
@@ -282,6 +286,7 @@ export const builtinDirectives = [
     providedBy: DirectiveProvidedBy.MarpCore,
     type: DirectiveType.Global,
     details: 'https://github.com/marp-team/marp-core#size-global-directive',
+    completable: true,
   }),
 
   // Marp CLI metadata options

diff --git a/src/language/completions.ts b/src/language/completions.ts
@@ -228,6 +228,12 @@ class CompletionProvider {
             kind: CompletionItemKind.Property,
             label: d.name,
             range,
+            command: d.completable
+              ? {
+                  command: 'editor.action.triggerSuggest',
+                  title: 'Trigger suggest',
+                }
+              : undefined,
           })
         )
     )