Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox pulls docker image from local registry #1

Open
wants to merge 2 commits into
base: mainline
Choose a base branch
from

Conversation

aryanagarwal9
Copy link

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    tox file builds the docker image itself

  • What is the new behavior (if this is a feature change)?
    GitHub workflow builds the docker file, pushes it to the local registry, then that image is pulled by the tox file, and used to run the tests

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:
    Please have a quick go through of the tox file to check if any more modifications are needed

@pandu-k
Copy link
Collaborator

pandu-k commented Sep 26, 2022

Hi Aryan, thanks for this PR.

Can we make the pull-from-local registry tests be in addition to building and running the tests?

In some cases we will still want to run-and-build. For example, if we want to run this test suite directly on a remote machine.

I propose we create two sets of tests: one is build and test (the existing structure) and one pulls from the local registry (for use on GitHub CI).

By default, it should run build and test (via the tox command with no args). The tests that pull from the local registry should be specified to run (e.g: tox -e dind_os_local_registry)

Copy link
Collaborator

@pandu-k pandu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update according to my comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants