Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples scripts updated for breaking changes #529

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

pandu-k
Copy link
Collaborator

@pandu-k pandu-k commented Jul 6, 2023

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Examples update, to be in line with 0.1.0's breaking changes.

What is the current behavior? (You can also link to an open issue here)

For the scripts in the /examples dir:

  1. Not all add_documents() calls have create_index() before them
  2. add_documents() calls still use server_batch_size and processes arguments

What is the new behavior (if this is a feature change)?

For the scripts in the /examples dir:

  1. All add_documents() calls now have create_index() before them
  2. All add_documents() calls no longer use server_batch_size and processes arguments

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No (the examples will still work on older Marqo versions)

Have unit tests been run against this PR? (Has there also been any additional testing?)
No

  • Related Python client changes (link commit/PR here)
    n/a

  • Related documentation changes (link commit/PR here)
    n/a

  • Other information:
    n/a

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

…ents calls have create_index() calls before them
@pandu-k pandu-k merged commit 7567386 into mainline Jul 6, 2023
@pandu-k pandu-k deleted the pandu/update_example_scripts branch July 6, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants