-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Add_documents API #535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
temporarily deployed
to
marqo-test-suite
July 11, 2023 08:22
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
July 12, 2023 02:02
— with
GitHub Actions
Inactive
farshidz
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed I suggest avoiding old and new in names so that we can easily remove the deprecated API in the future
farshidz
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
we move the query parameters
non_tensor_fields
,use_existing_tensors
,image_download_headers
,model_auth
,mappings
to the request body.What is the current behavior? (You can also link to an open issue here)
non_tensor_fields
,use_existing_tensors
,image_download_headers
,model_auth
,mappings
are query parametersWhat is the new behavior (if this is a feature change)?
they are now moved to the query body as
nonTensorFields, useExistingTensors, imageDownloadHeaders, modelAuth, mappings
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
yes.
for py-marqo users, they need to upgrade the py-marqo version
for bash curl users, they need to change their requests
marqo will still support old APIs recently but my remove them in the near future.
Have unit tests been run against this PR? (Has there also been any additional testing?)
running
Related Python client changes (link commit/PR here)
working on
Related documentation changes (link commit/PR here)
finished
Other information:
Please check if the PR fulfills these requirements