-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support searchable attributes for unstructured indexes #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papa99do
had a problem deploying
to
marqo-test-suite
September 15, 2024 04:49
— with
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
September 15, 2024 04:50
— with
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
September 15, 2024 04:50
— with
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
September 15, 2024 13:22
— with
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
September 15, 2024 13:23
— with
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
September 15, 2024 13:23
— with
GitHub Actions
Failure
papa99do
force-pushed
the
yihan/searchable-attributes-unstructured
branch
from
September 16, 2024 00:52
912d57f
to
93a67da
Compare
papa99do
had a problem deploying
to
marqo-test-suite
September 16, 2024 00:54
— with
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
September 16, 2024 00:54
— with
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
September 16, 2024 00:55
— with
GitHub Actions
Failure
papa99do
force-pushed
the
yihan/searchable-attributes-unstructured
branch
from
September 16, 2024 06:15
93a67da
to
420b6c4
Compare
papa99do
had a problem deploying
to
marqo-test-suite
September 16, 2024 06:17
— with
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
September 16, 2024 06:17
— with
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
September 16, 2024 06:19
— with
GitHub Actions
Failure
papa99do
force-pushed
the
yihan/searchable-attributes-unstructured
branch
from
September 16, 2024 10:43
420b6c4
to
31aac27
Compare
papa99do
had a problem deploying
to
marqo-test-suite
September 16, 2024 10:44
— with
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
September 16, 2024 10:44
— with
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
September 16, 2024 10:46
— with
GitHub Actions
Failure
papa99do
force-pushed
the
yihan/searchable-attributes-unstructured
branch
from
September 16, 2024 10:53
31aac27
to
81e193e
Compare
papa99do
had a problem deploying
to
marqo-test-suite
September 16, 2024 10:54
— with
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
September 16, 2024 10:54
— with
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
September 16, 2024 10:55
— with
GitHub Actions
Failure
papa99do
force-pushed
the
yihan/searchable-attributes-unstructured
branch
from
September 17, 2024 07:27
245ab62
to
5ad91dd
Compare
papa99do
had a problem deploying
to
marqo-test-suite
September 17, 2024 07:29
— with
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
September 17, 2024 07:29
— with
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
September 17, 2024 07:30
— with
GitHub Actions
Failure
papa99do
force-pushed
the
yihan/searchable-attributes-unstructured
branch
from
September 17, 2024 10:26
5ad91dd
to
38396cb
Compare
papa99do
had a problem deploying
to
marqo-test-suite
September 17, 2024 10:28
— with
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
September 17, 2024 10:28
— with
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
September 17, 2024 10:29
— with
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
October 4, 2024 22:59
— with
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
October 5, 2024 11:45
— with
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
October 5, 2024 11:45
— with
GitHub Actions
Failure
papa99do
had a problem deploying
to
marqo-test-suite
October 5, 2024 11:47
— with
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
October 5, 2024 22:24
— with
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
October 5, 2024 22:25
— with
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
October 6, 2024 11:12
— with
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
October 6, 2024 11:12
— with
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
October 6, 2024 11:13
— with
GitHub Actions
Inactive
farshidz
reviewed
Oct 6, 2024
farshidz
reviewed
Oct 6, 2024
src/marqo/core/semi_structured_vespa_index/semi_structured_add_document_handler.py
Outdated
Show resolved
Hide resolved
papa99do
had a problem deploying
to
marqo-test-suite
October 7, 2024 01:32
— with
GitHub Actions
Error
papa99do
had a problem deploying
to
marqo-test-suite
October 7, 2024 01:33
— with
GitHub Actions
Error
papa99do
had a problem deploying
to
marqo-test-suite
October 7, 2024 01:35
— with
GitHub Actions
Error
papa99do
temporarily deployed
to
marqo-test-suite
October 7, 2024 01:47
— with
GitHub Actions
Inactive
papa99do
temporarily deployed
to
marqo-test-suite
October 7, 2024 01:48
— with
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
October 7, 2024 01:48
— with
GitHub Actions
Error
farshidz
requested changes
Oct 7, 2024
papa99do
temporarily deployed
to
marqo-test-suite
October 7, 2024 03:27
— with
GitHub Actions
Inactive
papa99do
had a problem deploying
to
marqo-test-suite
October 7, 2024 03:28
— with
GitHub Actions
Failure
papa99do
temporarily deployed
to
marqo-test-suite
October 7, 2024 03:30
— with
GitHub Actions
Inactive
farshidz
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Searchable attributes is not supported for unstructured index since we store embeddings of all tensor fields in one field, and all string fields in one vespa field.
What is the new behavior (if this is a feature change)?
Searchable attributes is for unstructured index. When new documents are added to an unstructured index, new lexical and tensor fields are dynamically added to the index. This allows user to specify searchable attributes to selectively search on certain fields when using tensor, lexical or hybrid search.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes
Related Python client changes (link commit/PR here)
N/A. Client will remain the same
Related documentation changes (link commit/PR here)
To be provided
Other information:
This PR also include the following changes which are required to add this feature