Upgrade Pillow and nltk for vulnerability reasons #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
wanliAlex
force-pushed
the
li/update-pillow-nltk
branch
from
f6c901c
to
2d086a1
Compare
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
force-pushed
the
li/update-pillow-nltk
branch
from
4d29cc3
to
8142bbc
Compare
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
approved these changes
Oct 7, 2024
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
reviewed
Oct 8, 2024
| @@ -30,6 +30,12 @@ def _splitting_functions(split_by: str, language: str='english') -> FunctionType | |||
| except LookupError: | |||
| nltk.download("punkt") | |||
|
|
|||
| # Punkt_tab needs to be downloaded after NLTK 3.8 and later | |||
There was a problem hiding this comment.
It is needed in the text split. Previously it was downloaded along with "punkt" but now we need to download it explicitly after the upgrade.
There was a problem hiding this comment.
An error will be raised if we do not do this downloading
farshidz
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix
What is the current behavior? (You can also link to an open issue here)
The existing pillow and nltk dependencies have vulnerability concerns
What is the new behavior (if this is a feature change)?
we upgrade pillow to 10.4.0 and nltk to 3.9.1
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Have unit tests been run against this PR? (Has there also been any additional testing?)
no
Related Python client changes (link commit/PR here)
no
Related documentation changes (link commit/PR here)
Manual tests have been done to ensure that these changes won't change the embeddings.
Other information:
no
Please check if the PR fulfills these requirements