increase timeout, make sure cleanup continues on failure

marqo-ai · Sep 20, 2024 · 3c37e54 · 3c37e54
1 parent 299e9bf
commit 3c37e54
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/cloud-integration-tests.yml b/.github/workflows/cloud-integration-tests.yml
@@ -30,7 +30,7 @@ permissions:
 jobs:
   integration_tests:
     name: Cloud Integration Tests
-    timeout-minutes: 75     # Hard cap of 1 hour 15 mins for workflow
+    timeout-minutes: 80     # Hard cap of 1 hour 20 mins for workflow
     runs-on: ubuntu-latest
     if: ${{ github.event.inputs.job_to_run == 'run_integration_tests' || github.event_name != 'workflow_dispatch' }}
     environment: cloud-tests
@@ -66,6 +66,7 @@ jobs:
     runs-on : ubuntu-latest
     needs: integration_tests
     if: always()  # Run this job regardless of success or failure of the integration_tests job
+    continue-on-error: true # Do not fail the workflow if this job fails
     environment: cloud-tests
 
     steps:

diff --git a/tests/cloud_test_logic/run_cloud_tests.py b/tests/cloud_test_logic/run_cloud_tests.py
@@ -44,7 +44,7 @@ def run_pytest(pytest_args):
     return pytest.main(pytest_args)
 
 def run_pytest_with_timeout():
-    TIMEOUT_SECONDS = 45 * 60  # 45 minute timeout
+    TIMEOUT_SECONDS = 45 * 60  # 45 minute timeout (Full suite takes ~10 mins now 9/20/24)
     pytest_args = ['tests/', '--cloud'] + sys.argv[1:]
 
     # Use ThreadPoolExecutor to run pytest in a separate thread