Skip version check for cloud v2 rightnow #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicilliar
reviewed
Jul 17, 2023
src/marqo/client.py
Outdated
| f"{minimum_supported_marqo_version()} to function properly, while your Marqo version is {marqo_version}. " | ||
| f"Please upgrade your Marqo instance to avoid potential errors. " | ||
| f"If you have already upgraded your Marqo instance but still having this warning, please import you Marqo Python client again and retry.") | ||
| except JSONDecodeError as e: |
There was a problem hiding this comment.
In what situation do we see a JSONDecodeError happening in the version check?
There was a problem hiding this comment.
When it reaches the cloud v2 API and it is not in the skip list. One example is “https://api.marqo.ai/api/”
farshidz
requested changes
Jul 17, 2023
farshidz
requested changes
Jul 17, 2023
farshidz
requested changes
Jul 18, 2023
| self.assertEqual(marqo_url_and_version_cache, dict({self.client_settings["url"] : "_skipped"})) | ||
|
|
||
| marqo_url_and_version_cache.clear() | ||
|
|
||
| def test_version_check_multiple_instantiation(self): |
There was a problem hiding this comment.
Can we have one test similar to this but for skipped scenario, where we make sure multiple instantiations make only one get_marqo attempt and also log a warning?
farshidz
approved these changes
Jul 18, 2023
catch mainline
catch mainline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
we skip the version check for cloud v2
What is the current behavior? (You can also link to an open issue here)
we have the version check for all urls
What is the new behavior (if this is a feature change)?
we skip version check for specific urls
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information:
no