PyPi-push CI changes: unit tests, include releases/* branches #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To Do: - consider adding a "needs" section
pandu-k
changed the title
pandu-k
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
* added unit tests jobs To Do: - consider adding a "needs" section * Update publish-to-PyPI.yml * Update open-source-unit-tests.yml * Update open-source-unit-tests.yml
pandu-k
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
pandu-k
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
pandu-k
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
pandu-k
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
pandu-k
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
pandu-k
commented
Aug 10, 2023
vicilliar
requested changes
Aug 10, 2023
| @@ -20,12 +20,10 @@ on: | |||
| image_tag: | |||
| description: 'Marqo image tag. Examples: "1.1.0", "test" "latest"' | |||
| required: true | |||
| push: | |||
| branches: | |||
| - mainline | |||
| pull_request: | |||
There was a problem hiding this comment.
just clarifying this runs unit tests every time there's a push to a mainline or releases branch, right? If so, this might be a good thing to add to the marqo repo as well.
There was a problem hiding this comment.
Do you mean the pull_requests trigger? It runs every time there is a push to a branch that is in PR directed at mainline/releases. This would be really useful to be added to Marqo too (I plan to add this to Marqo at some point)
There was a problem hiding this comment.
yep i meant the pull_requests trigger. Does it also run when the pull request itself is created, or only on pushes to it? Also doing a bit of research, the pull_request_review trigger may also be cool to think about. But that can be done another time.
pandu-k
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
CI pipeline update
What is the current behavior? (You can also link to an open issue here)
PyPi-push CI only runs on pushes to mainline, does not run unit tests.
The unit tests pipeline also runs on pushes to mainline.
What is the new behavior (if this is a feature change)?
PyPi-push CI now also runs on branches matching the
releases/*pattern. The pipeline also runs unit tests, which must pass, before being pushed to PyPi.The unit tests pipeline no longer also runs on pushes to mainline, as these tests are run in the upgraded push-to-pypi workflow
The unit tests pipeline now also runs on update to PRs matching the
releases/*pattern.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Testing
After changes are merged, the follow tests will be run through:
Notes and observations