add hybrid_parameters to search #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicilliar
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
py-marqo-test-suite
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
requested changes
Jul 10, 2024
src/marqo/models/search_models.py
Outdated
| Tensor = 'tensor' | ||
| Lexical = 'lexical' | ||
|
|
||
| class HybridParameters: |
There was a problem hiding this comment.
Should this be a pydantic class and the field names are in camelCase?
There was a problem hiding this comment.
Ah yep it should be a pydantic class. We want the field names in snake case though, right?
There was a problem hiding this comment.
Yes, the original field name should be in the snake case for the Python client user. Note that the query sent to Marqo should be converted to the camelCase as APIs using the alias feature.
tests/v2_tests/test_hybrid_search.py
Outdated
| """ | ||
|
|
||
| index_test_cases = [ | ||
| (CloudTestIndex.structured_text, self.structured_index_name) # TODO: unstructured |
There was a problem hiding this comment.
TODO for unstructured indexes
vicilliar
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
vicilliar
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
previously approved these changes
Jul 10, 2024
vicilliar
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
wanliAlex
requested changes
Jul 10, 2024
| from abc import ABC | ||
| from enum import Enum | ||
|
|
||
| from pydantic import validator, BaseModel, root_validator |
There was a problem hiding this comment.
nit: Let's do an import clean to remove a lot of unused imports
farshidz
had a problem deploying
to
py-marqo-test-suite
GitHub Actions
Failure
farshidz
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
No hybrid search parameters
What is the new behavior (if this is a feature change)?
New parameter:
hybrid_parametersadded tosearchendpoint to enable hybrid searchDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: