Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for the new nhle schedule API #91

Merged
merged 18 commits into from
Nov 29, 2023
Merged

Support for the new nhle schedule API #91

merged 18 commits into from
Nov 29, 2023

Conversation

martbhell
Copy link
Owner

@martbhell martbhell commented Nov 27, 2023 •
edited
Loading

was thinking to

  • add a new endpoint that manages this new schedule, but then why keep the old one it doesn't work anymore anyway?
  • decide if keeping any more weeks worth of games (like whole season) - or just keep it simple for now and keep the next week? So everything calling wtangy.se/DET/DATE+8 or higher will return NO..

@martbhell
a test script to test the schedule
6a51fb4
@martbhell
new filename for new schedule
ac65221
@martbhell
making schedule output look quite similar
f1c0b86
@martbhell
make URL to fetch some extra weeks worth of games
9d69372
@martbhell
this looks the same as before
f6691e1
@martbhell
have these in testing too
1b52061
@martbhell
use the new NHL API
590e74a 
Have manually uploaded the new schedule because I recall something part
of this didn't work when there wasn't an existing schedule

Removed totalgames because that is no longer in the orignal JSON.

We could re-create it by counting lists in the dict ?
@martbhell
some todos
61904cb 
schedule in testing looks almost ok :)
@martbhell
Make schedule look like it used to
174c122 
```
{
  "teamdates": {
      "2023-09-23": [
            [
	            "Arizo
```

Before this change teamdates was a list of gameWeeks
@martbhell
e2e_test: next month (and some days 100 too)
3acef6f 
That > 100 days which aren't in the schedule. I'm just curious right now
what that API will return when the season is over.

Problem for another day :)
martbhell
martbhell commented Nov 28, 2023
View reviewed changes
src/main.py Outdated Show resolved Hide resolved
@martbhell
content and old content is already json loaded?
307316e
@martbhell
This is now a string.
f19fe25 
Maybe should use another function to upload?
@martbhell
some json decode error..
a5066bd 
this is pretty bad

on.decoder.JSONDecodeError: Expecting property name enclosed in double
quotes: line 1 column 2 (char 1)" Please enter the commit message for your changes. Lines starting
@martbhell
So let's try to replace this everywhere
b5e8de3 
pretty sure some confusion or loads vs dumps..
@martbhell
one more for the road
21a572b
@martbhell
testing files erroneously added
d2bea0c
@martbhell
Remove old links to old api
0fd954f
@martbhell
remove old test file for old api parsing
1063e04
@martbhell martbhell mentioned this pull request Nov 29, 2023
Open
@martbhell martbhell merged commit ad08f04 into master Nov 29, 2023
7 checks passed
@martbhell martbhell deleted the new_schedule_api branch November 29, 2023 20:33
@martbhell martbhell mentioned this pull request Nov 29, 2023
Closed
@martbhell martbhell changed the title a test script to test the schedule Support for the new nhle schedule API Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martbhell