Potential fix for CSS and SCSS issues #96
Conversation
| : includes; | ||
| nextCssLoader.issuer.exclude = excludes; | ||
| } | ||
| nextCssLoader.issuer.or = nextCssLoader.issuer.and ? nextCssLoader.issuer.and.concat(includes) : includes; |
There was a problem hiding this comment.
is this supposed to concat to issuer.or?
you're deleting the and property right after, so I'm assuming this doesn't do anything in the then case.
There was a problem hiding this comment.
Well, we want to use or so it matches the app directory, or one of the directory in the node_modules (the ones supplied as parameters of the plugin) 🤔
I removed the delete just in case.
There was a problem hiding this comment.
oh I read this wrong. of course, concat is immutable.
|
Thanks for putting this together so quickly. I gave this a try and it doesn't seem to fix my issues. It doesn't seem to work even after applying my suggested fix in #96 (comment). Doing that + adding back the |
|
It does however fix the issue with yarn workspaces. 👍 |
|
Thank you guys for testing 🙌 I will continue working on this to solve your issue @anmonteiro |
|
FYI, this PR fixes my issue that I've described here: vercel/next.js#15540 |
|
@justincy are you using Wepback 4 or 5? |
|
@martpie I assume it's webpack 5 because that's default in Next v9.5, right? |
|
Well no, it's only opt-in |
|
@martpie Oh. Then it's probably webpack 4. How do I figure out which version I'm using? |
|
if you don't know, then it's probably webpack 4 ;) |
|
@anmonteiro in theory, this should be fixed, can you confirm? Unless the |
|
hey @martpie this still doesn't work as is, but it's now my fault for telling you to not |
|
You mean if I revert e4f693e it works for you? 🙃 |
|
correct! |
|
well let's release then! |
Potentially fix for:
TODO: