Fixed css bugs and added features to datagrid #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
wachterjohannes
force-pushed
the
feature/custom-urls
branch
from
8dbb713
to
7ac9d06
Compare
wachterjohannes
force-pushed
the
feature/custom-urls
branch
from
7ac9d06
to
770282c
Compare
| @@ -442,7 +444,7 @@ define(function() { | |||
| if (!!this.options.selectItem && !!this.options.selectItem.type) { | |||
| var $cell = this.sandbox.dom.createElement(templates.headerCell); | |||
| this.sandbox.dom.addClass($cell, constants.checkboxCellClass); | |||
| if (this.options.selectItem.type === selectItems.CHECKBOX) { | |||
| if (this.options.selectItem.type === selectItems.CHECKBOX && this.options.disabledItems.length === 0) { | |||
There was a problem hiding this comment.
What is rendered if there are some disabledItems?
There was a problem hiding this comment.
Or the better question is: Shouldn't there be a possibility to select all non-disabled items?
There was a problem hiding this comment.
i have introduced this feature but i don't need it in the master PR i will extract it into an own PR which can be discussed separately.
|
@wachterjohannes We should also create better PRs in Husky, a simple link to the main PR is not enough. What exact css bugs are fixed here? That's probably not described anywhere, or is it? |
wachterjohannes
force-pushed
the
feature/custom-urls
branch
2 times, most recently
from
ace2d82
to
6cc47fd
Compare
| * BUGFIX #616 Fixed label tick in firefox | ||
| * ENHANCEMENT #615 Introduced no-img-icon as function to use record dependent icons | ||
| * BUGFIX #613 Fixed search-icon to prevent routing | ||
| * FEATURE #610 Added save parameter for datagrid | ||
| ======= | ||
| * FEATURE #597 Fixed css bugs and added features to datagrid | ||
| >>>>>>> c820cfb... added disabled items in table view |
wachterjohannes
force-pushed
the
feature/custom-urls
branch
from
6cc47fd
to
98e7a38
Compare
wachterjohannes
force-pushed
the
feature/custom-urls
branch
from
98e7a38
to
34f415a
Compare
wachterjohannes
added a commit
that referenced
this pull request
Mar 18, 2016
Fixed css bugs and added features to datagrid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR sulu/sulu#1927