Introduced info text for dropdown #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
wachterjohannes
force-pushed
the
feature/dropdown-info-text
branch
7 times, most recently
from
8409634
to
a199ea1
Compare
wachterjohannes
force-pushed
the
feature/dropdown-info-text
branch
from
a41fed6
to
86686cf
Compare
| @@ -33,6 +33,8 @@ define([], function() { | |||
| shadow: true, // if box-shadow should be shown | |||
| toggleClassOn: null, // container to set is-active class | |||
| valueName: 'name', // name of text property | |||
| infoName: 'info', // name of info property (used to display hover info) | |||
| clickedName: 'clickedInfo', // name of info property (used to display clicked info) | |||
There was a problem hiding this comment.
Why name? What is this actually doing? Are these the translations?
There was a problem hiding this comment.
they are property names
There was a problem hiding this comment.
And what do these properties contain?
There was a problem hiding this comment.
a info for a hover and the info when you click on the item
wachterjohannes
force-pushed
the
feature/dropdown-info-text
branch
from
86686cf
to
c1d4958
Compare
| && !( | ||
| $(event.target).hasClass('husky-dropdown-item') | ||
| || $(event.target).parents().hasClass('husky-dropdown-item') | ||
| ) |
There was a problem hiding this comment.
Can't the previous two && be connected to one? Maybe some filter that checks if the element has one class and doesn't have another one? Maybe also the two next statements can somehow be included like this.
wachterjohannes
force-pushed
the
feature/dropdown-info-text
branch
from
c1d4958
to
f89aa9b
Compare
| // reapply the hide listener | ||
| if (!!event | ||
| && ($(event.target).is('.husky-dropdown-trigger:not(.husky-dropdown-item), .highlight-animation') | ||
| || $(event.target).parents().is('.husky-dropdown-trigger:not(.husky-dropdown-item), .highlight-animation') |
There was a problem hiding this comment.
Didn't you put the result of $(event.target) into its own variable.
wachterjohannes
force-pushed
the
feature/dropdown-info-text
branch
from
f89aa9b
to
91ad1c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added info texts for dropdown items. Additionally the stopPropagation is removed to use this event outside of the dropdown (sulu for copy to clipboard sulu/sulu#2155).