Added navigation divider for sections with no title #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
enhancement/navigation-structure
branch
from
3fdcd7b
to
c6f2246
Compare
| @@ -57,7 +57,7 @@ | |||
| return key; | |||
| } | |||
|
|
|||
| return !!translation ? translation : key; | |||
| return !!translation || translation === '' ? translation : key; | |||
There was a problem hiding this comment.
Some brackets would probably make more clear what's happening here. And what does it actually do?
There was a problem hiding this comment.
it return the value if it is not null or an empty string.
wachterjohannes
force-pushed
the
enhancement/navigation-structure
branch
from
c6f2246
to
442bdca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a divider for navigation sections without a title. Additionally it adds the support to define default-messages. For example if a message in FR is not there it would take the default messages (EN for example).
This code will be used in sulu/sulu#2196