Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ckeditor plugin registry #643

Merged
merged 3 commits into from
May 31, 2016
Merged

Added ckeditor plugin registry #643

merged 3 commits into from
May 31, 2016

Conversation

wachterjohannes
Copy link
Member

@wachterjohannes wachterjohannes commented Apr 26, 2016

This PR adds the ability to register ckeditor plugins.

Example:

In a aura-extension:

sandbox.ckeditor.addPlugin(
    'internalLink',
    {
        init: function(editor) {
...
        }
    }
);
sandbox.ckeditor.addToolbarButton('links', 'InternalLink');

@wachterjohannes wachterjohannes force-pushed the feature/ckeditor-plugins branch 5 times, most recently from 83b67a4 to 5243d75 Compare May 2, 2016 06:27
@wachterjohannes wachterjohannes force-pushed the feature/ckeditor-plugins branch 4 times, most recently from 44558a0 to 44c4996 Compare May 19, 2016 12:23
@wachterjohannes wachterjohannes force-pushed the feature/ckeditor-plugins branch 3 times, most recently from ce2b5b3 to 8a07899 Compare May 25, 2016 07:48
@@ -23,7 +23,7 @@
}
});

define(['ckeditor', 'jqueryAdapter'], function() {
define(['underscore', 'ckeditor', 'jqueryAdapter'], function(_) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need 'ckeditor' and 'jqueryAdapter' here, although it is not passed to the function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need it to be sure that it is loaded by require. this scripts will add some global vars and constructor's we need.

@wachterjohannes
Copy link
Member Author

@danrot fixed

@danrot danrot merged commit fd18380 into develop May 31, 2016
@danrot danrot deleted the feature/ckeditor-plugins branch May 31, 2016 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants