-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ckeditor plugin registry #643
Conversation
523ef8e
to
479adc3
Compare
83b67a4
to
5243d75
Compare
44558a0
to
44c4996
Compare
ce2b5b3
to
8a07899
Compare
8a07899
to
2a84369
Compare
@@ -23,7 +23,7 @@ | |||
} | |||
}); | |||
|
|||
define(['ckeditor', 'jqueryAdapter'], function() { | |||
define(['underscore', 'ckeditor', 'jqueryAdapter'], function(_) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need 'ckeditor'
and 'jqueryAdapter'
here, although it is not passed to the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need it to be sure that it is loaded by require. this scripts will add some global vars and constructor's we need.
@danrot fixed |
b08ef05
to
adcf4b1
Compare
This PR adds the ability to register ckeditor plugins.
Example:
In a aura-extension: