Record deleted(by mod) status to prevent re-appear #10732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
requested changes
May 9, 2019
|
Thanks for comment. I agree that using tombstone instead of making another table is performance better. |
|
Yes, I think I'd add a field to |
|
Oh that's seems good. |
|
They are added when running the migration in the development environment. Usually I add them manually 🤷 |
|
Thanks! |
ClearlyClaire
requested changes
May 9, 2019
db/schema.rb
Outdated
| t.datetime "created_at", default: -> { "now()" }, null: false | ||
| t.datetime "updated_at", default: -> { "now()" }, null: false | ||
| t.datetime "created_at", default: -> { "CURRENT_TIMESTAMP" }, null: false | ||
| t.datetime "updated_at", default: -> { "CURRENT_TIMESTAMP" }, null: false | ||
| t.index ["account_id", "status_id"], name: "index_status_pins_on_account_id_and_status_id", unique: true |
There was a problem hiding this comment.
I am not sure why these changes were made?
There was a problem hiding this comment.
IDK too.. But db:migrate makes that.
ClearlyClaire
approved these changes
May 9, 2019
2 tasks
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Record deleted(by mod) status to prevent re-appear * Move to Tombstone * Add missing migration script
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
* Record deleted(by mod) status to prevent re-appear * Move to Tombstone * Add missing migration script
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
* Record deleted(by mod) status to prevent re-appear * Move to Tombstone * Add missing migration script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #10731
Like Tombstone, deleted status by moderation should not be re-appeared on timeline.