Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement variable height in single column layout #10917

Conversation

noellabo
Copy link
Contributor

@noellabo noellabo commented Jun 1, 2019

This is an improvement to make the height of compose panel and navigation panel in single column layout variable from fixed length.

In the case where the compose panel has the longest vertical length, the following is assumed.

  • Warning display of status visibility (WarningContainer)
  • Display of reply source (ReplyIndicatorContainer)
  • Field for spoiler text (AutosuggestInput)
  • Compose form (AutosuggestTextarea)
  • Attached image (UploadFormContainer) or poll form (PollFormContainer)

I made adjustments to make it possible to display this at the same time.

Also for the navigation panel, the vertical length gets longer depending on the number of lists, so we scroll only when necessary.

Check the animated GIF for behavior.
compose_form

@noellabo
Copy link
Contributor Author

noellabo commented Jun 2, 2019

Now that we have confirmed the operation on Microsoft Edge, remove the WIP.
Please comment if you need to fix it.

However, my changes have made AutosuggestTextarea go beyond its original role. This requires splitting, but I do not know how to write the appropriate code. Someone, please merge this PR and then refactor it.

@noellabo noellabo changed the title [WIP] Improvement variable height in single column layout Improvement variable height in single column layout Jun 2, 2019
@Gargron Gargron merged commit d93b82a into mastodon:master Jun 2, 2019
hiyuki2578 pushed a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Improvement variable height of compose and navigation panel in single column layout

* Fix wrong quotes and missing commas
rtucker pushed a commit to vulpineclub/mastodon that referenced this pull request Jan 7, 2021
* Improvement variable height of compose and navigation panel in single column layout

* Fix wrong quotes and missing commas
messenjahofchrist pushed a commit to Origin-Creative/mastodon that referenced this pull request Jul 30, 2021
* Improvement variable height of compose and navigation panel in single column layout

* Fix wrong quotes and missing commas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants