Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix & improvement for the Dockerfile #14686

Merged
merged 2 commits into from
Aug 30, 2020
Merged

Conversation

ryncsn
Copy link
Contributor

@ryncsn ryncsn commented Aug 30, 2020

Hi, I deployed Mastodon on my arm64 K8s cluster, and most part worked well. But the dockerfile doesn't build. so I made some minor fix and improvement.

@shleeable
Copy link
Contributor

shleeable commented Aug 30, 2020

Changes make sense. Can you jump nodejs LTS to v12.18.3?

@Gargron Gargron merged commit 03b5f09 into mastodon:master Aug 30, 2020
@shleeable
Copy link
Contributor

Guess that's a no ;)

thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 6, 2020
* Dockerfile: Fix building with multiarch

Tested on amd64 and arm64

* Reduce docker image size by clean up some unneeded source file
thenameisnigel-old pushed a commit to ChatterlyOSE/Chatterly that referenced this pull request Sep 7, 2020
* Dockerfile: Fix building with multiarch

Tested on amd64 and arm64

* Reduce docker image size by clean up some unneeded source file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants