Correct hashtag warning #22827
Correct hashtag warning #22827
Conversation
Posts with any visibility setting that is not 'Public' are prevented from being listed under any hashtag.
I personally think the current wording is fine, it recalls the selected visibility (unlisted), and says that only posts with public visibility are listed in the hashtag timelines. I feel like with your change, the first sentence is just paraphrasing the second one, while the current wording recalls the selected visibility.
Yes, that's the way to go! Translations are managed via Crowdin, so changing translations in PRs are to be avoided as this is likely to cause merge conflicts when merging the translation updates from Crowdin. |
Oh, nevermind… I somehow missed that it's shown for other selected visibilities as well 😅 I think it could recall the selected visibility, but that's probably more trouble than it's worth. Your proposal is fine! |
Would've done the same, but there's a very good reason why I didn't choose to implement this: I don't know Ruby. :D |
Posts with any visibility setting that is not 'Public' are prevented from being listed under any hashtag.
Posts with any visibility setting that is not 'Public' are prevented from being listed under any hashtag.
P.S. I did not update the string in other locales, e.g.
en-GB, under the assumption that this would be done by the translators and because of similar pull requests by reputable contributors not containing such changes. Hope that's OK.